-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchanges: Update Binance #1546
Open
samuael
wants to merge
159
commits into
thrasher-corp:master
Choose a base branch
from
samuael:binance_update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into update_binance
… into binance_futures_ws_update
… into binance_update
… into binance_update
… into binance_update
shazbert
added
the
tests require fixing
This is to denote that the PR has some tests that require fixing before the review can be completed
label
Sep 28, 2024
… into binance_update
… into binance_update
… into binance_update
12 tasks
… into binance_update
… into binance_update
shazbert
removed
rebase/merge of master required
tests require fixing
This is to denote that the PR has some tests that require fixing before the review can be completed
labels
Nov 20, 2024
… into binance_update
… into binance_update
… into binance_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR updates the Binance exchange by addressing WebSocket enhancements, adding or updating endpoints, and implementing unit tests for each endpoint, along with mock records. Additionally, it introduces new endpoints under European Options and Portfolio Margin and extends WebSocket streaming support for futures and spot endpoints. The new WebSocket streaming functionality supports USDT-margined and coin-margined futures assets, establishing connections and managing incoming stream data separately. Furthermore, this PR adds a group of endpoints that utilize endpoint calls through the WebSocket stream, building on the previous Binance WebSocket update.
Type of change
Please delete options that are not relevant and add an
x
in[]
as the item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also, consider improving test coverage whilst working on a certain feature or package.
Checklist